Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control the number of rows in chunks returned by LimitExec (#9354) #9359

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Control the number of rows in chunks returned by LimitExec (#9354) #9359

merged 3 commits into from
Feb 20, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Feb 19, 2019

cherry pick from #9354

@qw4990 qw4990 requested review from lysu and zz-jason and removed request for lysu February 19, 2019 11:51
@qw4990 qw4990 added the sig/execution SIG execution label Feb 19, 2019
@qw4990 qw4990 requested a review from lysu February 19, 2019 11:51
@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 20, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2019
zz-jason
zz-jason reviewed Feb 20, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 20, 2019

@lysu PTAL~

lysu
lysu approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 20, 2019
@ngaut ngaut merged commit 7513f0c into pingcap:release-2.1 Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @zz-jason @lysu @ngaut